mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-23 03:05:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

fix subtle refcount big in filter() -- Tim MacKenzie

Browse source
This commit is contained in:
Guido van Rossum 1995-01-10 17:40:55 +00:00
parent 630112ed04
commit 58b6873f6b
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Python/bltinmodule.c
View file

@ -186,21 +186,22 @@ builtin_filter(self, args)
if (func == None) { if (func == None) {
good = item; good = item;
INCREF(good);
} }
else { else {
object *arg = mkvalue("(O)", item); object *arg = mkvalue("(O)", item);
DECREF(item);
if (arg == NULL) if (arg == NULL)
goto Fail_1; goto Fail_1;
good = call_object(func, arg); good = call_object(func, arg);
DECREF(arg); DECREF(arg);
if (good == NULL) if (good == NULL) {
DECREF(item);
goto Fail_1; goto Fail_1;
}
} }
ok = testbool(good); ok = testbool(good);
DECREF(good); DECREF(good);
if (ok) { if (ok) {
INCREF(item);
if (j < len) { if (j < len) {
if (setlistitem(result, j++, item) < 0) if (setlistitem(result, j++, item) < 0)
goto Fail_1; goto Fail_1;
@ -210,6 +211,8 @@ builtin_filter(self, args)
if (addlistitem(result, item) < 0) if (addlistitem(result, item) < 0)
goto Fail_1; goto Fail_1;
} }
} else {
DECREF(item);
} }
} }