Issue #18810: Be optimistic with stat calls when seeing if a directory

Browse source

exists when checking for a package.

Before there was an isdir check and then various isfile checks for
possible __init__ files when looking for a package.
This change drops the isdir check by leaning
on the assumption that a directory will not contain something named
after the module being imported which is not a directory. If the module
is a package then it saves a stat call. If there is nothing in the
directory with the potential package name it also saves a stat call.
Only if there is something in the directory named the same thing as
the potential package will the number of stat calls increase
(due to more wasteful __init__ checks).

Semantically there is no change as the isdir check moved
down so that namespace packages continue to have no chance of
accidentally collecting non-existent directories.

...

This commit is contained in:

Brett Cannon 2013-10-18 13:24:13 -04:00

parent 2546a17765

commit 58f5680462

2 changed files with 777 additions and 779 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1537

Python/importlib.h

View file

File diff suppressed because it is too large Load diff