mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

subprocess now emits a ResourceWarning warning

Browse source 
Issue #26741: subprocess.Popen destructor now emits a ResourceWarning warning
if the child process is still running.
This commit is contained in:
Victor Stinner 2016-05-20 12:11:15 +02:00
parent a58e2c5c49
commit 5a48e21ff1
5 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/subprocess.py
View file

@ -1006,6 +1006,9 @@ class Popen(object):
if not self._child_created:
# We didn't get to successfully create a child process.
return
if self.returncode is None:
warnings.warn("running subprocess %r" % self, ResourceWarning,
source=self)
# In case the child hasn't been waited on, check if it's done.
self._internal_poll(_deadstate=_maxsize)
if self.returncode is None and _active is not None: