mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

subprocess now emits a ResourceWarning warning

Browse source 
Issue #26741: subprocess.Popen destructor now emits a ResourceWarning warning
if the child process is still running.
This commit is contained in:
Victor Stinner 2016-05-20 12:11:15 +02:00
parent a58e2c5c49
commit 5a48e21ff1
5 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_subprocess.py
View file

@ -2286,7 +2286,9 @@ class POSIXProcessTestCase(BaseTestCase):
self.addCleanup(p.stderr.close)
ident = id(p)
pid = p.pid
del p
with support.check_warnings(('', ResourceWarning)):
p = None
# check that p is in the active processes list
self.assertIn(ident, [id(o) for o in subprocess._active])
@ -2305,7 +2307,9 @@ class POSIXProcessTestCase(BaseTestCase):
self.addCleanup(p.stderr.close)
ident = id(p)
pid = p.pid
del p
with support.check_warnings(('', ResourceWarning)):
p = None
os.kill(pid, signal.SIGKILL)
# check that p is in the active processes list
self.assertIn(ident, [id(o) for o in subprocess._active])