mirror of
https://github.com/python/cpython.git
synced 2025-07-15 23:35:23 +00:00
gh-111964: Add _PyRWMutex a "readers-writer" lock (gh-112859)
This adds `_PyRWMutex`, a "readers-writer" lock, which wil be used to serialize global stop-the-world pauses with per-interpreter pauses.
This commit is contained in:
parent
40574da019
commit
5ae75e1be2
3 changed files with 244 additions and 0 deletions
106
Python/lock.c
106
Python/lock.c
|
@ -353,3 +353,109 @@ _PyOnceFlag_CallOnceSlow(_PyOnceFlag *flag, _Py_once_fn_t *fn, void *arg)
|
|||
v = _Py_atomic_load_uint8(&flag->v);
|
||||
}
|
||||
}
|
||||
|
||||
#define _Py_WRITE_LOCKED 1
|
||||
#define _PyRWMutex_READER_SHIFT 2
|
||||
#define _Py_RWMUTEX_MAX_READERS (UINTPTR_MAX >> _PyRWMutex_READER_SHIFT)
|
||||
|
||||
static uintptr_t
|
||||
rwmutex_set_parked_and_wait(_PyRWMutex *rwmutex, uintptr_t bits)
|
||||
{
|
||||
// Set _Py_HAS_PARKED and wait until we are woken up.
|
||||
if ((bits & _Py_HAS_PARKED) == 0) {
|
||||
uintptr_t newval = bits | _Py_HAS_PARKED;
|
||||
if (!_Py_atomic_compare_exchange_uintptr(&rwmutex->bits,
|
||||
&bits, newval)) {
|
||||
return bits;
|
||||
}
|
||||
bits = newval;
|
||||
}
|
||||
|
||||
_PyParkingLot_Park(&rwmutex->bits, &bits, sizeof(bits), -1, NULL, 1);
|
||||
return _Py_atomic_load_uintptr_relaxed(&rwmutex->bits);
|
||||
}
|
||||
|
||||
// The number of readers holding the lock
|
||||
static uintptr_t
|
||||
rwmutex_reader_count(uintptr_t bits)
|
||||
{
|
||||
return bits >> _PyRWMutex_READER_SHIFT;
|
||||
}
|
||||
|
||||
void
|
||||
_PyRWMutex_RLock(_PyRWMutex *rwmutex)
|
||||
{
|
||||
uintptr_t bits = _Py_atomic_load_uintptr_relaxed(&rwmutex->bits);
|
||||
for (;;) {
|
||||
if ((bits & _Py_WRITE_LOCKED)) {
|
||||
// A writer already holds the lock.
|
||||
bits = rwmutex_set_parked_and_wait(rwmutex, bits);
|
||||
continue;
|
||||
}
|
||||
else if ((bits & _Py_HAS_PARKED)) {
|
||||
// Reader(s) hold the lock (or just gave up the lock), but there is
|
||||
// at least one waiting writer. We can't grab the lock because we
|
||||
// don't want to starve the writer. Instead, we park ourselves and
|
||||
// wait for the writer to eventually wake us up.
|
||||
bits = rwmutex_set_parked_and_wait(rwmutex, bits);
|
||||
continue;
|
||||
}
|
||||
else {
|
||||
// The lock is unlocked or read-locked. Try to grab it.
|
||||
assert(rwmutex_reader_count(bits) < _Py_RWMUTEX_MAX_READERS);
|
||||
uintptr_t newval = bits + (1 << _PyRWMutex_READER_SHIFT);
|
||||
if (!_Py_atomic_compare_exchange_uintptr(&rwmutex->bits,
|
||||
&bits, newval)) {
|
||||
continue;
|
||||
}
|
||||
return;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
void
|
||||
_PyRWMutex_RUnlock(_PyRWMutex *rwmutex)
|
||||
{
|
||||
uintptr_t bits = _Py_atomic_add_uintptr(&rwmutex->bits, -(1 << _PyRWMutex_READER_SHIFT));
|
||||
assert(rwmutex_reader_count(bits) > 0 && "lock was not read-locked");
|
||||
bits -= (1 << _PyRWMutex_READER_SHIFT);
|
||||
|
||||
if (rwmutex_reader_count(bits) == 0 && (bits & _Py_HAS_PARKED)) {
|
||||
_PyParkingLot_UnparkAll(&rwmutex->bits);
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
void
|
||||
_PyRWMutex_Lock(_PyRWMutex *rwmutex)
|
||||
{
|
||||
uintptr_t bits = _Py_atomic_load_uintptr_relaxed(&rwmutex->bits);
|
||||
for (;;) {
|
||||
// If there are no active readers and it's not already write-locked,
|
||||
// then we can grab the lock.
|
||||
if ((bits & ~_Py_HAS_PARKED) == 0) {
|
||||
if (!_Py_atomic_compare_exchange_uintptr(&rwmutex->bits,
|
||||
&bits,
|
||||
bits | _Py_WRITE_LOCKED)) {
|
||||
continue;
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
// Otherwise, we have to wait.
|
||||
bits = rwmutex_set_parked_and_wait(rwmutex, bits);
|
||||
}
|
||||
}
|
||||
|
||||
void
|
||||
_PyRWMutex_Unlock(_PyRWMutex *rwmutex)
|
||||
{
|
||||
uintptr_t old_bits = _Py_atomic_exchange_uintptr(&rwmutex->bits, 0);
|
||||
|
||||
assert((old_bits & _Py_WRITE_LOCKED) && "lock was not write-locked");
|
||||
assert(rwmutex_reader_count(old_bits) == 0 && "lock was read-locked");
|
||||
|
||||
if ((old_bits & _Py_HAS_PARKED) != 0) {
|
||||
_PyParkingLot_UnparkAll(&rwmutex->bits);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue