mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-08 08:01:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 20

bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)

Browse source
This commit is contained in:
Serhiy Storchaka 2019-03-05 10:06:26 +02:00 • committed by GitHub
parent 9e4861f523
commit 5b10b98247
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 253 additions and 312 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Lib/test/test_argparse.py
View file

@ -1379,9 +1379,8 @@ class TestArgumentsFromFile(TempDirMixin, ParserTestCase):
('invalid', '@no-such-path\n'),
]
for path, text in file_texts:
file = open(path, 'w')
file.write(text)
file.close()
with open(path, 'w') as file:
file.write(text)
parser_signature = Sig(fromfile_prefix_chars='@')
argument_signatures = [
@ -1410,9 +1409,8 @@ class TestArgumentsFromFileConverter(TempDirMixin, ParserTestCase):
('hello', 'hello world!\n'),
]
for path, text in file_texts:
file = open(path, 'w')
file.write(text)
file.close()
with open(path, 'w') as file:
file.write(text)
class FromFileConverterArgumentParser(ErrorRaisingArgumentParser):
@ -1493,9 +1491,8 @@ class TestFileTypeR(TempDirMixin, ParserTestCase):
def setUp(self):
super(TestFileTypeR, self).setUp()
for file_name in ['foo', 'bar']:
file = open(os.path.join(self.temp_dir, file_name), 'w')
file.write(file_name)
file.close()
with open(os.path.join(self.temp_dir, file_name), 'w') as file:
file.write(file_name)
self.create_readonly_file('readonly')
argument_signatures = [
@ -1534,9 +1531,8 @@ class TestFileTypeRB(TempDirMixin, ParserTestCase):
def setUp(self):
super(TestFileTypeRB, self).setUp()
for file_name in ['foo', 'bar']:
file = open(os.path.join(self.temp_dir, file_name), 'w')
file.write(file_name)
file.close()
with open(os.path.join(self.temp_dir, file_name), 'w') as file:
file.write(file_name)
argument_signatures = [
Sig('-x', type=argparse.FileType('rb')),