bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)

This commit is contained in:
Serhiy Storchaka 2019-03-05 10:06:26 +02:00 committed by GitHub
parent 9e4861f523
commit 5b10b98247
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 253 additions and 312 deletions

View file

@ -20,13 +20,11 @@ class BoolTest(unittest.TestCase):
def test_print(self):
try:
fo = open(support.TESTFN, "w")
print(False, True, file=fo)
fo.close()
fo = open(support.TESTFN, "r")
self.assertEqual(fo.read(), 'False True\n')
with open(support.TESTFN, "w") as fo:
print(False, True, file=fo)
with open(support.TESTFN, "r") as fi:
self.assertEqual(fi.read(), 'False True\n')
finally:
fo.close()
os.remove(support.TESTFN)
def test_repr(self):
@ -245,9 +243,8 @@ class BoolTest(unittest.TestCase):
def test_fileclosed(self):
try:
f = open(support.TESTFN, "w")
self.assertIs(f.closed, False)
f.close()
with open(support.TESTFN, "w") as f:
self.assertIs(f.closed, False)
self.assertIs(f.closed, True)
finally:
os.remove(support.TESTFN)