mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)

Browse source
This commit is contained in:
Serhiy Storchaka 2019-03-05 10:06:26 +02:00 • committed by GitHub
parent 9e4861f523
commit 5b10b98247
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 253 additions and 312 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Lib/test/test_xmlrpc.py
View file

@ -821,10 +821,9 @@ class SimpleServerTestCase(BaseServerTestCase):
def test_404(self):
# send POST with http.client, it should return 404 header and
# 'Not Found' message.
conn = http.client.HTTPConnection(ADDR, PORT)
conn.request('POST', '/this-is-not-valid')
response = conn.getresponse()
conn.close()
with contextlib.closing(http.client.HTTPConnection(ADDR, PORT)) as conn:
conn.request('POST', '/this-is-not-valid')
response = conn.getresponse()
self.assertEqual(response.status, 404)
self.assertEqual(response.reason, 'Not Found')
@ -944,9 +943,8 @@ class SimpleServerTestCase(BaseServerTestCase):
def test_partial_post(self):
# Check that a partial POST doesn't make the server loop: issue #14001.
conn = http.client.HTTPConnection(ADDR, PORT)
conn.request('POST', '/RPC2 HTTP/1.0\r\nContent-Length: 100\r\n\r\nbye')
conn.close()
with contextlib.closing(http.client.HTTPConnection(ADDR, PORT)) as conn:
conn.request('POST', '/RPC2 HTTP/1.0\r\nContent-Length: 100\r\n\r\nbye')
def test_context_manager(self):
with xmlrpclib.ServerProxy(URL) as server: