bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)

This commit is contained in:
Serhiy Storchaka 2019-03-05 10:06:26 +02:00 committed by GitHub
parent 9e4861f523
commit 5b10b98247
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 253 additions and 312 deletions

View file

@ -122,15 +122,13 @@ class ZipSupportTests(unittest.TestCase):
test_src)
zip_name, run_name = make_zip_script(d, 'test_zip',
script_name)
z = zipfile.ZipFile(zip_name, 'a')
for mod_name, src in sample_sources.items():
z.writestr(mod_name + ".py", src)
z.close()
with zipfile.ZipFile(zip_name, 'a') as z:
for mod_name, src in sample_sources.items():
z.writestr(mod_name + ".py", src)
if verbose:
zip_file = zipfile.ZipFile(zip_name, 'r')
print ('Contents of %r:' % zip_name)
zip_file.printdir()
zip_file.close()
with zipfile.ZipFile(zip_name, 'r') as zip_file:
print ('Contents of %r:' % zip_name)
zip_file.printdir()
os.remove(script_name)
sys.path.insert(0, zip_name)
import test_zipped_doctest