mirror of
https://github.com/python/cpython.git
synced 2025-10-10 00:43:41 +00:00
Merge in r68394 fixing itertools.permutations() and combinations().
This commit is contained in:
parent
5e4e4278c9
commit
5bad41eefc
3 changed files with 47 additions and 22 deletions
|
@ -75,11 +75,11 @@ class TestBasicOps(unittest.TestCase):
|
|||
self.assertRaises(TypeError, list, chain.from_iterable([2, 3]))
|
||||
|
||||
def test_combinations(self):
|
||||
self.assertRaises(TypeError, combinations, 'abc') # missing r argument
|
||||
self.assertRaises(TypeError, combinations, 'abc') # missing r argument
|
||||
self.assertRaises(TypeError, combinations, 'abc', 2, 1) # too many arguments
|
||||
self.assertRaises(TypeError, combinations, None) # pool is not iterable
|
||||
self.assertRaises(ValueError, combinations, 'abc', -2) # r is negative
|
||||
self.assertRaises(ValueError, combinations, 'abc', 32) # r is too big
|
||||
self.assertEqual(list(combinations('abc', 32)), []) # r > n
|
||||
self.assertEqual(list(combinations(range(4), 3)),
|
||||
[(0,1,2), (0,1,3), (0,2,3), (1,2,3)])
|
||||
|
||||
|
@ -87,6 +87,8 @@ class TestBasicOps(unittest.TestCase):
|
|||
'Pure python version shown in the docs'
|
||||
pool = tuple(iterable)
|
||||
n = len(pool)
|
||||
if r > n:
|
||||
return
|
||||
indices = list(range(r))
|
||||
yield tuple(pool[i] for i in indices)
|
||||
while 1:
|
||||
|
@ -110,9 +112,9 @@ class TestBasicOps(unittest.TestCase):
|
|||
|
||||
for n in range(7):
|
||||
values = [5*x-12 for x in range(n)]
|
||||
for r in range(n+1):
|
||||
for r in range(n+2):
|
||||
result = list(combinations(values, r))
|
||||
self.assertEqual(len(result), fact(n) / fact(r) / fact(n-r)) # right number of combs
|
||||
self.assertEqual(len(result), 0 if r>n else fact(n) / fact(r) / fact(n-r)) # right number of combs
|
||||
self.assertEqual(len(result), len(set(result))) # no repeats
|
||||
self.assertEqual(result, sorted(result)) # lexicographic order
|
||||
for c in result:
|
||||
|
@ -123,7 +125,7 @@ class TestBasicOps(unittest.TestCase):
|
|||
self.assertEqual(list(c),
|
||||
[e for e in values if e in c]) # comb is a subsequence of the input iterable
|
||||
self.assertEqual(result, list(combinations1(values, r))) # matches first pure python version
|
||||
self.assertEqual(result, list(combinations2(values, r))) # matches first pure python version
|
||||
self.assertEqual(result, list(combinations2(values, r))) # matches second pure python version
|
||||
|
||||
# Test implementation detail: tuple re-use
|
||||
self.assertEqual(len(set(map(id, combinations('abcde', 3)))), 1)
|
||||
|
@ -134,7 +136,7 @@ class TestBasicOps(unittest.TestCase):
|
|||
self.assertRaises(TypeError, permutations, 'abc', 2, 1) # too many arguments
|
||||
self.assertRaises(TypeError, permutations, None) # pool is not iterable
|
||||
self.assertRaises(ValueError, permutations, 'abc', -2) # r is negative
|
||||
self.assertRaises(ValueError, permutations, 'abc', 32) # r is too big
|
||||
self.assertEqual(list(permutations('abc', 32)), []) # r > n
|
||||
self.assertRaises(TypeError, permutations, 'abc', 's') # r is not an int or None
|
||||
self.assertEqual(list(permutations(range(3), 2)),
|
||||
[(0,1), (0,2), (1,0), (1,2), (2,0), (2,1)])
|
||||
|
@ -144,6 +146,8 @@ class TestBasicOps(unittest.TestCase):
|
|||
pool = tuple(iterable)
|
||||
n = len(pool)
|
||||
r = n if r is None else r
|
||||
if r > n:
|
||||
return
|
||||
indices = list(range(n))
|
||||
cycles = list(range(n-r+1, n+1))[::-1]
|
||||
yield tuple(pool[i] for i in indices[:r])
|
||||
|
@ -172,9 +176,9 @@ class TestBasicOps(unittest.TestCase):
|
|||
|
||||
for n in range(7):
|
||||
values = [5*x-12 for x in range(n)]
|
||||
for r in range(n+1):
|
||||
for r in range(n+2):
|
||||
result = list(permutations(values, r))
|
||||
self.assertEqual(len(result), fact(n) / fact(n-r)) # right number of perms
|
||||
self.assertEqual(len(result), 0 if r>n else fact(n) / fact(n-r)) # right number of perms
|
||||
self.assertEqual(len(result), len(set(result))) # no repeats
|
||||
self.assertEqual(result, sorted(result)) # lexicographic order
|
||||
for p in result:
|
||||
|
@ -182,7 +186,7 @@ class TestBasicOps(unittest.TestCase):
|
|||
self.assertEqual(len(set(p)), r) # no duplicate elements
|
||||
self.assert_(all(e in values for e in p)) # elements taken from input iterable
|
||||
self.assertEqual(result, list(permutations1(values, r))) # matches first pure python version
|
||||
self.assertEqual(result, list(permutations2(values, r))) # matches first pure python version
|
||||
self.assertEqual(result, list(permutations2(values, r))) # matches second pure python version
|
||||
if r == n:
|
||||
self.assertEqual(result, list(permutations(values, None))) # test r as None
|
||||
self.assertEqual(result, list(permutations(values))) # test default r
|
||||
|
@ -1384,6 +1388,26 @@ perform as purported.
|
|||
>>> list(combinations_with_replacement('abc', 2))
|
||||
[('a', 'a'), ('a', 'b'), ('a', 'c'), ('b', 'b'), ('b', 'c'), ('c', 'c')]
|
||||
|
||||
>>> list(combinations_with_replacement('01', 3))
|
||||
[('0', '0', '0'), ('0', '0', '1'), ('0', '1', '1'), ('1', '1', '1')]
|
||||
|
||||
>>> def combinations_with_replacement2(iterable, r):
|
||||
... 'Alternate version that filters from product()'
|
||||
... pool = tuple(iterable)
|
||||
... n = len(pool)
|
||||
... for indices in product(range(n), repeat=r):
|
||||
... if sorted(indices) == list(indices):
|
||||
... yield tuple(pool[i] for i in indices)
|
||||
|
||||
>>> list(combinations_with_replacement('abc', 2)) == list(combinations_with_replacement2('abc', 2))
|
||||
True
|
||||
|
||||
>>> list(combinations_with_replacement('01', 3)) == list(combinations_with_replacement2('01', 3))
|
||||
True
|
||||
|
||||
>>> list(combinations_with_replacement('2310', 6)) == list(combinations_with_replacement2('2310', 6))
|
||||
True
|
||||
|
||||
>>> list(unique_everseen('AAAABBBCCDAABBB'))
|
||||
['A', 'B', 'C', 'D']
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue