mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

bpo-40737: Fix possible reference leak for sqlite3 initialization (GH-20323)

Browse source
This commit is contained in:
Erlend Egeberg Aasland 2020-05-26 14:18:19 +02:00 • committed by GitHub
parent be63019ed7
commit 5eb45d7d4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2020-05-23-00-22-11.bpo-40737.iph-CM.rst Normal file
View file

@ -0,0 +1 @@
Fix possible reference leak for :mod:`sqlite3` initialization.

20
Modules/_sqlite/module.c
View file

@ -346,6 +346,14 @@ static struct PyModuleDef _sqlite3module = {
NULL NULL
}; };
#define ADD_TYPE(module, type) \
do { \
if (PyModule_AddType(module, &type) < 0) { \
Py_DECREF(module); \
return NULL; \
} \
} while (0)
PyMODINIT_FUNC PyInit__sqlite3(void) PyMODINIT_FUNC PyInit__sqlite3(void)
{ {
PyObject *module, *dict; PyObject *module, *dict;
@ -366,14 +374,10 @@ PyMODINIT_FUNC PyInit__sqlite3(void)
return NULL; return NULL;
} }
Py_INCREF(&pysqlite_ConnectionType); ADD_TYPE(module, pysqlite_ConnectionType);
PyModule_AddObject(module, "Connection", (PyObject*) &pysqlite_ConnectionType); ADD_TYPE(module, pysqlite_CursorType);
Py_INCREF(&pysqlite_CursorType); ADD_TYPE(module, pysqlite_PrepareProtocolType);
PyModule_AddObject(module, "Cursor", (PyObject*) &pysqlite_CursorType); ADD_TYPE(module, pysqlite_RowType);
Py_INCREF(&pysqlite_PrepareProtocolType);
PyModule_AddObject(module, "PrepareProtocol", (PyObject*) &pysqlite_PrepareProtocolType);
Py_INCREF(&pysqlite_RowType);
PyModule_AddObject(module, "Row", (PyObject*) &pysqlite_RowType);
if (!(dict = PyModule_GetDict(module))) { if (!(dict = PyModule_GetDict(module))) {
goto error; goto error;