mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-14 10:53:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-109582: test_fork_signal_handling should wait for event (#109605)

Browse source 
Sometimes the child_handled event was missing because either
the child quits before it gets a chance to handle the signal,
or the parent asserts before the event notification is
delivered via IPC.  Synchronize explicitly to avoid this.
This commit is contained in:
Davide Rizzo 2023-09-21 23:20:29 +02:00 • committed by GitHub
parent 2aceb21ae6
commit 608c1f3083
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Lib/test/test_asyncio/test_unix_events.py
View file

@ -11,9 +11,11 @@ import socket
import stat
import sys
import threading
import time
import unittest
from unittest import mock
import warnings
from test import support
from test.support import os_helper
from test.support import socket_helper
from test.support import wait_process
@ -1911,8 +1913,14 @@ class TestFork(unittest.IsolatedAsyncioTestCase):
parent_handled = manager.Event()
def child_main():
signal.signal(signal.SIGTERM, lambda *args: child_handled.set())
def on_sigterm(*args):
child_handled.set()
sys.exit()
signal.signal(signal.SIGTERM, on_sigterm)
child_started.set()
while True:
time.sleep(1)
async def main():
loop = asyncio.get_running_loop()
@ -1922,7 +1930,7 @@ class TestFork(unittest.IsolatedAsyncioTestCase):
process.start()
child_started.wait()
os.kill(process.pid, signal.SIGTERM)
process.join()
process.join(timeout=support.SHORT_TIMEOUT)
async def func():
await asyncio.sleep(0.1)
@ -1933,6 +1941,7 @@ class TestFork(unittest.IsolatedAsyncioTestCase):
asyncio.run(main())
child_handled.wait(timeout=support.SHORT_TIMEOUT)
self.assertFalse(parent_handled.is_set())
self.assertTrue(child_handled.is_set())