mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-25 12:44:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Issue 22663: fix redirect vulnerability in urllib/urllib2.

Browse source
This commit is contained in:
guido@google.com 2011-03-24 08:07:45 -07:00
parent ce5d0e22fc
commit 60a4a90c8d
2 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Lib/urllib2.py
View file

@ -555,6 +555,13 @@ class HTTPRedirectHandler(BaseHandler):
return
newurl = urlparse.urljoin(req.get_full_url(), newurl)
# For security reasons we do not allow redirects to protocols
# other than HTTP or HTTPS.
newurl_lower = newurl.lower()
if not (newurl_lower.startswith('http://') or
newurl_lower.startswith('https://')):
return
# XXX Probably want to forget about the state of the current
# request, although that might interact poorly with other
# handlers that also use handler-specific request attributes