mirror of
https://github.com/python/cpython.git
synced 2025-09-26 10:19:53 +00:00
vgetargskeywords: Removed one of the mysterious PyErr_Clear() calls.
The "need" for this was probably removed by an earlier patch that stopped the loop right before it from passing NULL to a dict lookup routine. I still haven't convinced myself that the next loop is correct, so am leaving the next mysterious PyErr_Clear() call in for now.
This commit is contained in:
parent
b054be41c0
commit
61dde63e3b
1 changed files with 1 additions and 10 deletions
|
@ -1099,18 +1099,9 @@ vgetargskeywords(PyObject *args, PyObject *keywords, char *format,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
/* XXX The loop just above didn't used to break when hitting the
|
|
||||||
end of kwlist, so could pass NULL on to PyMapping_HasKeyString,
|
|
||||||
which sets a "NULL argument to internal routine" error then.
|
|
||||||
However, the comment below doesn't give any clues about which
|
|
||||||
'error string' it's talking about, so darned hard to say whether
|
|
||||||
the PyErr_Clear() still serves a purpose.
|
|
||||||
*/
|
|
||||||
PyErr_Clear(); /* I'm not which Py functions set the error string */
|
|
||||||
|
|
||||||
/* required arguments missing from args can be supplied by keyword
|
/* required arguments missing from args can be supplied by keyword
|
||||||
arguments */
|
arguments */
|
||||||
|
|
||||||
len = nargs;
|
len = nargs;
|
||||||
if (keywords && nargs < min) {
|
if (keywords && nargs < min) {
|
||||||
for (i = nargs; i < min; i++) {
|
for (i = nargs; i < min; i++) {
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue