mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-31291: Fixed an assertion failure in zipimport.zipimporter.get_data() (#3226)

Browse source 
if pathname.replace('/', '\\') returns non-string.
This commit is contained in:
Oren Milman 2017-08-29 20:40:15 +03:00 • committed by Serhiy Storchaka
parent 006617ff7d
commit 631fdee6e6
3 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Lib/test/test_zipimport.py
View file

@ -521,6 +521,23 @@ class UncompressedZipImportTestCase(ImportHooksBaseTestCase):
z.close()
os.remove(TEMP_ZIP)
def test_issue31291(self):
# There shouldn't be an assertion failure in get_data().
class FunnyStr(str):
def replace(self, old, new):
return 42
z = ZipFile(TEMP_ZIP, "w")
try:
name = "test31291.dat"
data = b'foo'
z.writestr(name, data)
z.close()
zi = zipimport.zipimporter(TEMP_ZIP)
self.assertEqual(data, zi.get_data(FunnyStr(name)))
finally:
z.close()
os.remove(TEMP_ZIP)
def testImporterAttr(self):
src = """if 1: # indent hack
def get_file():