mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Issue #25791: Raise an ImportWarning when __spec__ or __package__ are

Browse source 
not defined for a relative import.

This is the start of work to try and clean up import semantics to rely
more on a module's spec than on the myriad attributes that get set on
a module. Thanks to Rose Ames for the patch.
This commit is contained in:
Brett Cannon 2016-01-15 13:33:03 -08:00
parent 43cfd8240c
commit 63b8505281
7 changed files with 381 additions and 315 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Lib/test/test_importlib/import_/test___package__.py
View file

@ -33,31 +33,39 @@ class Using__package__:
"""
def test_using___package__(self):
# [__package__]
def import_module(self, globals_):
with self.mock_modules('pkg.__init__', 'pkg.fake') as importer:
with util.import_state(meta_path=[importer]):
self.__import__('pkg.fake')
module = self.__import__('',
globals={'__package__': 'pkg.fake'},
globals=globals_,
fromlist=['attr'], level=2)
return module
def test_using___package__(self):
# [__package__]
module = self.import_module({'__package__': 'pkg.fake'})
self.assertEqual(module.__name__, 'pkg')
def test_using___name__(self, package_as_None=False):
def test_using___name__(self):
# [__name__]
globals_ = {'__name__': 'pkg.fake', '__path__': []}
if package_as_None:
globals_['__package__'] = None
with self.mock_modules('pkg.__init__', 'pkg.fake') as importer:
with util.import_state(meta_path=[importer]):
self.__import__('pkg.fake')
module = self.__import__('', globals= globals_,
fromlist=['attr'], level=2)
self.assertEqual(module.__name__, 'pkg')
module = self.import_module({'__name__': 'pkg.fake', '__path__': []})
self.assertEqual(module.__name__, 'pkg')
def test_warn_when_using___name__(self):
with self.assertWarns(ImportWarning):
self.import_module({'__name__': 'pkg.fake', '__path__': []})
def test_None_as___package__(self):
# [None]
self.test_using___name__(package_as_None=True)
module = self.import_module({
'__name__': 'pkg.fake', '__path__': [], '__package__': None })
self.assertEqual(module.__name__, 'pkg')
def test_prefers___spec__(self):
globals = {'__spec__': FakeSpec()}
with self.assertRaises(SystemError):
self.__import__('', globals, {}, ['relimport'], 1)
def test_bad__package__(self):
globals = {'__package__': '<not real>'}
@ -70,6 +78,10 @@ class Using__package__:
self.__import__('', globals, {}, ['relimport'], 1)
class FakeSpec:
parent = '<fake>'
class Using__package__PEP302(Using__package__):
mock_modules = util.mock_modules