mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-31922: Do not connect UDP sockets when broadcast is allowed (GH-423)

Browse source 
*Moved from python/asyncio#493.*

This PR fixes issue python/asyncio#480, as explained in [this comment](https://github.com/python/asyncio/issues/480#issuecomment-278703828).

The `_SelectorDatagramTransport.sendto` method has to be modified ~~so `_sock.sendto` is used in all cases (because it is tricky to reliably tell if the socket is connected or not). Could that be an issue for connected sockets?~~ *EDIT* ... so `_sock.send` is used only if `_sock` is connected.

It also protects `socket.getsockname` against `OSError` in `_SelectorTransport`. This might happen on Windows if the socket is not connected (e.g. for UDP broadcasting).


https://bugs.python.org/issue31922
This commit is contained in:
Vincent Michel 2019-05-07 19:18:49 +02:00 • committed by Miss Islington (bot)
parent 91cc01f40e
commit 63deaa5b70
5 changed files with 34 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Lib/test/test_asyncio/test_selector_events.py
View file

@ -1065,6 +1065,7 @@ class SelectorDatagramTransportTests(test_utils.TestCase):
self.sock.fileno.return_value = 7
def datagram_transport(self, address=None):
self.sock.getpeername.side_effect = None if address else OSError
transport = _SelectorDatagramTransport(self.loop, self.sock,
self.protocol,
address=address)