mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-10 00:43:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 18

Issue #1512791: In setframerate method of Wave_write, round non-integral

Browse source 
inputs to the nearest integer.  Thanks Neil Tallim for the patch.
This commit is contained in:
Mark Dickinson 2010-08-28 17:22:16 +00:00
parent a62074883b
commit 64a38c0eb5
5 changed files with 21 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Lib/test/test_wave.py
View file

@ -22,11 +22,14 @@ class TestWave(unittest.TestCase):
except OSError:
pass
def test_it(self):
def test_it(self, test_rounding=False):
self.f = wave.open(TESTFN, 'wb')
self.f.setnchannels(nchannels)
self.f.setsampwidth(sampwidth)
self.f.setframerate(framerate)
if test_rounding:
self.f.setframerate(framerate - 0.1)
else:
self.f.setframerate(framerate)
self.f.setnframes(nframes)
output = b'\0' * nframes * nchannels * sampwidth
self.f.writeframes(output)
@ -39,6 +42,13 @@ class TestWave(unittest.TestCase):
self.assertEqual(nframes, self.f.getnframes())
self.assertEqual(self.f.readframes(nframes), output)
def test_fractional_framerate(self):
"""
Addresses [ 1512791 ] module wave does no rounding
Floating point framerates should be rounded, rather than truncated.
"""
self.test_it(test_rounding=True)
def test_issue7681(self):
self.f = wave.open(TESTFN, 'wb')
self.f.setnchannels(nchannels)