mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-30 20:31:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812) (GH-4466)

Browse source 
TimedRotatingFileHandler.getFilesToDelete() now sorts only when needed.
(cherry picked from commit afad147b59)
This commit is contained in:
Miss Islington (bot) 2017-11-19 10:43:49 -08:00 • committed by Vinay Sajip
parent 80baec58f5
commit 65dffe58dd
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/logging/handlers.py
View file

@ -356,10 +356,10 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
suffix = fileName[plen:] suffix = fileName[plen:]
if self.extMatch.match(suffix): if self.extMatch.match(suffix):
result.append(os.path.join(dirName, fileName)) result.append(os.path.join(dirName, fileName))
result.sort()
if len(result) < self.backupCount: if len(result) < self.backupCount:
result = [] result = []
else: else:
result.sort()
result = result[:len(result) - self.backupCount] result = result[:len(result) - self.backupCount]
return result return result