mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 02:39:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Don't write "if self.dict: self.dict.close()"; just write

Browse source 
"self.dict.close()" and ignore the exception.  The "if self.dict:"
part would be calculated through len(self.dict.keys()), which is very
expensive for a large dictionary...
This commit is contained in:
Guido van Rossum 1998-03-26 22:12:22 +00:00
parent 3ec38f0ee4
commit 65e5399081
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/shelve.py
View file

@ -75,8 +75,7 @@ class Shelf:
def close(self): def close(self):
try: try:
if self.dict: self.dict.close()
self.dict.close()
except: except:
pass pass
self.dict = 0 self.dict = 0