mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 03:35:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #22182: Use e.args to unpack exceptions correctly in distutils.file_util.move_file.

Browse source 
Patch by Claudiu Popa.
This commit is contained in:
Berker Peksag 2014-08-29 07:07:35 +03:00
parent 59e0802301
commit 6685883c02
3 changed files with 25 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Lib/distutils/tests/test_file_util.py
View file

@ -2,10 +2,13 @@
import unittest
import os
import shutil
import errno
from unittest.mock import patch
from distutils.file_util import move_file
from distutils import log
from distutils.tests import support
from distutils.errors import DistutilsFileError
from test.support import run_unittest
class FileUtilTestCase(support.TempdirManager, unittest.TestCase):
@ -58,6 +61,23 @@ class FileUtilTestCase(support.TempdirManager, unittest.TestCase):
wanted = ['moving %s -> %s' % (self.source, self.target_dir)]
self.assertEqual(self._logs, wanted)
@patch('os.rename', side_effect=OSError('wrong', 1))
def test_move_file_exception_unpacking_rename(self, _):
# see issue 22182
with self.assertRaises(DistutilsFileError):
with open(self.source, 'w') as fobj:
fobj.write('spam eggs')
move_file(self.source, self.target, verbose=0)
@patch('os.rename', side_effect=OSError(errno.EXDEV, 'wrong'))
@patch('os.unlink', side_effect=OSError('wrong', 1))
def test_move_file_exception_unpacking_unlink(self, rename, unlink):
# see issue 22182
with self.assertRaises(DistutilsFileError):
with open(self.source, 'w') as fobj:
fobj.write('spam eggs')
move_file(self.source, self.target, verbose=0)
def test_suite():
return unittest.makeSuite(FileUtilTestCase)