mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 11:23:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Forbid an empty argument list in execv call.

Browse source 
Fixes issue 1039.
This commit is contained in:
Thomas Heller 2007-08-30 17:15:14 +00:00
parent 8a7c866e18
commit 6790d606ff
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_os.py
View file

@ -441,6 +441,9 @@ class ExecTests(unittest.TestCase):
def test_execvpe_with_bad_program(self): def test_execvpe_with_bad_program(self):
self.assertRaises(OSError, os.execvpe, 'no such app-', [], None) self.assertRaises(OSError, os.execvpe, 'no such app-', [], None)
def test_execvpe_with_bad_arglist(self):
self.assertRaises(ValueError, os.execvpe, 'notepad', [], None)
class Win32ErrorTests(unittest.TestCase): class Win32ErrorTests(unittest.TestCase):
def test_rename(self): def test_rename(self):
self.assertRaises(WindowsError, os.rename, test_support.TESTFN, test_support.TESTFN+".bak") self.assertRaises(WindowsError, os.rename, test_support.TESTFN, test_support.TESTFN+".bak")

5
Modules/posixmodule.c
View file

@ -2834,6 +2834,11 @@ posix_execv(PyObject *self, PyObject *args)
PyMem_Free(path); PyMem_Free(path);
return NULL; return NULL;
} }
if (argc < 1) {
PyErr_SetString(PyExc_ValueError, "execv() arg 2 must not be empty");
PyMem_Free(path);
return NULL;
}
argvlist = PyMem_NEW(char *, argc+1); argvlist = PyMem_NEW(char *, argc+1);
if (argvlist == NULL) { if (argvlist == NULL) {