mirror of
https://github.com/python/cpython.git
synced 2025-08-22 01:35:16 +00:00
Closes #7334: close source files on ElementTree.parse and iterparse (partial backport of issue #10093 from 3.2).
This commit is contained in:
parent
e96102b45b
commit
67d5d0ed44
3 changed files with 45 additions and 22 deletions
|
@ -642,17 +642,23 @@ class ElementTree(object):
|
|||
# @exception ParseError If the parser fails to parse the document.
|
||||
|
||||
def parse(self, source, parser=None):
|
||||
close_source = False
|
||||
if not hasattr(source, "read"):
|
||||
source = open(source, "rb")
|
||||
if not parser:
|
||||
parser = XMLParser(target=TreeBuilder())
|
||||
while 1:
|
||||
data = source.read(65536)
|
||||
if not data:
|
||||
break
|
||||
parser.feed(data)
|
||||
self._root = parser.close()
|
||||
return self._root
|
||||
close_source = True
|
||||
try:
|
||||
if not parser:
|
||||
parser = XMLParser(target=TreeBuilder())
|
||||
while 1:
|
||||
data = source.read(65536)
|
||||
if not data:
|
||||
break
|
||||
parser.feed(data)
|
||||
self._root = parser.close()
|
||||
return self._root
|
||||
finally:
|
||||
if close_source:
|
||||
source.close()
|
||||
|
||||
##
|
||||
# Creates a tree iterator for the root element. The iterator loops
|
||||
|
@ -1189,16 +1195,19 @@ def parse(source, parser=None):
|
|||
# @return A (event, elem) iterator.
|
||||
|
||||
def iterparse(source, events=None, parser=None):
|
||||
close_source = False
|
||||
if not hasattr(source, "read"):
|
||||
source = open(source, "rb")
|
||||
close_source = True
|
||||
if not parser:
|
||||
parser = XMLParser(target=TreeBuilder())
|
||||
return _IterParseIterator(source, events, parser)
|
||||
return _IterParseIterator(source, events, parser, close_source)
|
||||
|
||||
class _IterParseIterator(object):
|
||||
|
||||
def __init__(self, source, events, parser):
|
||||
def __init__(self, source, events, parser, close_source=False):
|
||||
self._file = source
|
||||
self._close_file = close_source
|
||||
self._events = []
|
||||
self._index = 0
|
||||
self.root = self._root = None
|
||||
|
@ -1249,6 +1258,8 @@ class _IterParseIterator(object):
|
|||
except IndexError:
|
||||
if self._parser is None:
|
||||
self.root = self._root
|
||||
if self._close_file:
|
||||
self._file.close()
|
||||
raise StopIteration
|
||||
# load event buffer
|
||||
del self._events[:]
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue