mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-01 07:33:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Issue #4197: Fix the remaining part of the doctest-in-zipfile problem by giving linecache access to the module globals when available

Browse source
This commit is contained in:
Nick Coghlan 2008-12-15 11:41:05 +00:00
parent 60b2e38b68
commit 68060013ea
2 changed files with 42 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Lib/doctest.py
View file

@ -820,7 +820,15 @@ class DocTestFinder:
# given object's docstring. # given object's docstring.
try: try:
file = inspect.getsourcefile(obj) or inspect.getfile(obj) file = inspect.getsourcefile(obj) or inspect.getfile(obj)
source_lines = linecache.getlines(file) if module is not None:
# Supply the module globals in case the module was
# originally loaded via a PEP 302 loader and
# file is not a valid filesystem path
source_lines = linecache.getlines(file, module.__dict__)
else:
# No access to a loader, so assume it's a normal
# filesystem path
source_lines = linecache.getlines(file)
if not source_lines: if not source_lines:
source_lines = None source_lines = None
except TypeError: except TypeError:
@ -1433,8 +1441,10 @@ class DocTestRunner:
d = self._name2ft d = self._name2ft
for name, (f, t) in other._name2ft.items(): for name, (f, t) in other._name2ft.items():
if name in d: if name in d:
print "*** DocTestRunner.merge: '" + name + "' in both" \ # Don't print here by default, since doing
" testers; summing outcomes." # so breaks some of the buildbots
#print "*** DocTestRunner.merge: '" + name + "' in both" \
# " testers; summing outcomes."
f2, t2 = d[name] f2, t2 = d[name]
f = f + f2 f = f + f2
t = t + t2 t = t + t2

29
Lib/test/test_zipimport_support.py
View file

@ -173,6 +173,35 @@ class ZipSupportTests(ImportHooksBaseTestCase):
for obj in known_good_tests: for obj in known_good_tests:
_run_object_doctest(obj, test_zipped_doctest) _run_object_doctest(obj, test_zipped_doctest)
def test_doctest_main_issue4197(self):
test_src = textwrap.dedent("""\
class Test:
">>> 'line 2'"
pass
import doctest
doctest.testmod()
""")
pattern = 'File "%s", line 2, in %s'
with temp_dir() as d:
script_name = _make_test_script(d, 'script', test_src)
exit_code, data = _run_python(script_name)
expected = pattern % (script_name, "__main__.Test")
if verbose:
print "Expected line", expected
print "Got stdout:"
print data
self.assert_(expected in data)
zip_name, run_name = _make_test_zip(d, "test_zip",
script_name, '__main__.py')
exit_code, data = _run_python(zip_name)
expected = pattern % (run_name, "__main__.Test")
if verbose:
print "Expected line", expected
print "Got stdout:"
print data
self.assert_(expected in data)
def test_pdb_issue4201(self): def test_pdb_issue4201(self):
test_src = textwrap.dedent("""\ test_src = textwrap.dedent("""\
def f(): def f():