mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-27 21:55:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-101819: Harden _io init (#104352)

Browse source 
Fix potential refleak if PyModule_AddObject() fails.
This commit is contained in:
Erlend E. Aasland 2023-05-10 12:59:03 +02:00 • committed by GitHub
parent 22f3425c3d
commit 68a8ca6dc1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Modules/_io/_iomodule.c
View file

@ -730,9 +730,11 @@ PyInit__io(void)
"UnsupportedOperation", PyExc_OSError, PyExc_ValueError); "UnsupportedOperation", PyExc_OSError, PyExc_ValueError);
if (state->unsupported_operation == NULL) if (state->unsupported_operation == NULL)
goto fail; goto fail;
if (PyModule_AddObject(m, "UnsupportedOperation", if (PyModule_AddObjectRef(m, "UnsupportedOperation",
Py_NewRef(state->unsupported_operation)) < 0) state->unsupported_operation) < 0)
{
goto fail; goto fail;
}
/* BlockingIOError, for compatibility */ /* BlockingIOError, for compatibility */
if (PyModule_AddObjectRef(m, "BlockingIOError", if (PyModule_AddObjectRef(m, "BlockingIOError",
@ -785,7 +787,6 @@ PyInit__io(void)
return m; return m;
fail: fail:
Py_XDECREF(state->unsupported_operation);
Py_DECREF(m); Py_DECREF(m);
return NULL; return NULL;
} }