mirror of
https://github.com/python/cpython.git
synced 2025-08-04 00:48:58 +00:00
#10053: Don't close FDs when FileIO.__init__ fails
Loosely based on the work by Hirokazu Yamamoto.
This commit is contained in:
commit
69168354c2
3 changed files with 20 additions and 6 deletions
|
@ -404,6 +404,17 @@ class OtherFileTests(unittest.TestCase):
|
|||
self.assertRaises(ValueError, _FileIO, "/some/invalid/name", "rt")
|
||||
self.assertEqual(w.warnings, [])
|
||||
|
||||
def testUnclosedFDOnException(self):
|
||||
class MyException(Exception): pass
|
||||
class MyFileIO(_FileIO):
|
||||
def __setattr__(self, name, value):
|
||||
if name == "name":
|
||||
raise MyException("blocked setting name")
|
||||
return super(MyFileIO, self).__setattr__(name, value)
|
||||
fd = os.open(__file__, os.O_RDONLY)
|
||||
self.assertRaises(MyException, MyFileIO, fd)
|
||||
os.close(fd) # should not raise OSError(EBADF)
|
||||
|
||||
|
||||
def test_main():
|
||||
# Historically, these tests have been sloppy about removing TESTFN.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue