mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-19 09:15:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Optimize string_repeat.

Browse source 
Christian Tismer pointed out the high cost of the loop overhead and
function call overhead for 'c' * n where n is large.  Accordingly,
the new code only makes lg2(n) loops.

Interestingly, 'c' * 1000 * 1000 ran a bit faster with old code.  At some
point, the loop and function call overhead became cheaper than invalidating
the cache with lengthy memcpys.  But for more typical sizes of n, the new
code runs much faster and for larger values of n it runs only a bit slower.
This commit is contained in:
Raymond Hettinger 2003-01-06 10:33:56 +00:00
parent 68b539ef9c
commit 698258a199
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Objects/stringobject.c
View file

@ -933,6 +933,7 @@ static PyObject *
string_repeat(register PyStringObject *a, register int n)
{
register int i;
register int j;
register int size;
register PyStringObject *op;
size_t nbytes;
@ -965,8 +966,16 @@ string_repeat(register PyStringObject *a, register int n)
PyObject_INIT_VAR(op, &PyString_Type, size);
op->ob_shash = -1;
op->ob_sstate = SSTATE_NOT_INTERNED;
for (i = 0; i < size; i += a->ob_size)
memcpy(op->ob_sval+i, a->ob_sval, (int) a->ob_size);
i = 0;
if (i < size) {
memcpy(op->ob_sval, a->ob_sval, (int) a->ob_size);
i = (int) a->ob_size;
}
while (i < size) {
j = (i <= size-i) ? i : size-i;
memcpy(op->ob_sval+i, op->ob_sval, j);
i += j;
}
op->ob_sval[size] = '\0';
return (PyObject *) op;
}