mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Fix a reference leak found by Georg, when compiling a class nested in another class.

Browse source 
Now "regrtest.py -R:: test_compile" is satisfied.

Will backport.
This commit is contained in:
Amaury Forgeot d'Arc 2008-03-28 20:30:50 +00:00
parent aa5fbdd71a
commit 69b747b735
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Misc/NEWS
View file

@ -12,6 +12,9 @@ What's New in Python 2.6 alpha 2?
Core and builtins Core and builtins
----------------- -----------------
- The compilation of a class nested in another class used to leak one
reference on the outer class name.
- Patch #1810: compile() can now compile _ast trees as returned by - Patch #1810: compile() can now compile _ast trees as returned by
compile(..., PyCF_ONLY_AST). compile(..., PyCF_ONLY_AST).

1
Python/compile.c
View file

@ -1431,6 +1431,7 @@ compiler_class(struct compiler *c, stmt_ty s)
if (!compiler_enter_scope(c, s->v.ClassDef.name, (void *)s, if (!compiler_enter_scope(c, s->v.ClassDef.name, (void *)s,
s->lineno)) s->lineno))
return 0; return 0;
Py_XDECREF(c->u->u_private);
c->u->u_private = s->v.ClassDef.name; c->u->u_private = s->v.ClassDef.name;
Py_INCREF(c->u->u_private); Py_INCREF(c->u->u_private);
str = PyString_InternFromString("__name__"); str = PyString_InternFromString("__name__");