From 69e7c9b1fd616c4c7c667e356be478db0df1dabf Mon Sep 17 00:00:00 2001 From: Jesus Cea Date: Fri, 5 Oct 2012 04:50:17 +0200 Subject: [PATCH] #16112: platform.architecture does not correctly escape argument to /usr/bin/file. Use 'communicate()' --- Lib/platform.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Lib/platform.py b/Lib/platform.py index d1774995738..10b04bde95e 100755 --- a/Lib/platform.py +++ b/Lib/platform.py @@ -1045,13 +1045,12 @@ def _syscmd_file(target,default=''): return default target = _follow_symlinks(target) try: - with open(DEV_NULL) as dev_null: - proc = subprocess.Popen(['file', '-b', '--', target], - stdout=subprocess.PIPE, stderr=dev_null) + proc = subprocess.Popen(['file', '-b', '--', target], + stdout=subprocess.PIPE, stderr=subprocess.DEVNULL) except (AttributeError,os.error): return default - output = proc.stdout.read() + output = proc.communicate()[0] rc = proc.wait() if not output or rc: return default