mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Issue #3657: Fix uninitialized memory read when pickling longs.

Browse source 
The conversion to the unicode API was incorrect, it should use bytes.
repr is a bad variable name.  The use is overloaded, but I'll leave
that to fix later.

R=Brett
TESTED=./python -E -tt ./Lib/test/regrtest.py -uall
	valgrind -q --leak-check=yes --suppressions=Misc/valgrind-python.supp \
		./python -E -tt ./Lib/test/regrtest.py test_pickletools
This commit is contained in:
Neal Norwitz 2008-08-24 23:50:08 +00:00
parent 6e0e0e6749
commit 6ae2eb268d
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Modules/_pickle.c
View file

@ -924,10 +924,10 @@ save_long(PicklerObject *self, PyObject *obj)
"long too large to pickle");
goto error;
}
repr = PyUnicode_FromStringAndSize(NULL, (int)nbytes);
repr = PyBytes_FromStringAndSize(NULL, (Py_ssize_t)nbytes);
if (repr == NULL)
goto error;
pdata = (unsigned char *)_PyUnicode_AsString(repr);
pdata = (unsigned char *)PyBytes_AS_STRING(repr);
i = _PyLong_AsByteArray((PyLongObject *)obj,
pdata, nbytes,
1 /* little endian */ , 1 /* signed */ );