mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 18:59:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

PyErr_NormalizeException(): in the type==NULL test, we should simply

Browse source 
return.  Setting an exception can mess with the exception state, and
continuing is definitely wrong (since type is dereferenced later on).
Some code that calls this seems to be prepared for a NULL exception
type, so let's be safe rather than sorry and simply assume there's
nothing to normalize in this case.
This commit is contained in:
Guido van Rossum 2003-04-10 20:29:48 +00:00
parent 594adac0bf
commit 6b3fffaf99
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Python/errors.c
View file

@ -131,9 +131,8 @@ PyErr_NormalizeException(PyObject **exc, PyObject **val, PyObject **tb)
PyObject *initial_tb = NULL; PyObject *initial_tb = NULL;
if (type == NULL) { if (type == NULL) {
/* This is a bug. Should never happen. Don't dump core. */ /* There was no exception, so nothing to do. */
PyErr_SetString(PyExc_SystemError, return;
"PyErr_NormalizeException() called without exception");
} }
/* If PyErr_SetNone() was used, the value will have been actually /* If PyErr_SetNone() was used, the value will have been actually