#5057: the peepholer no longer optimizes subscription on unicode literals (e.g. u"foo"[0]) in order to produce compatible pyc files between narrow and wide builds.

This commit is contained in:
Ezio Melotti 2012-11-05 00:06:32 +02:00
parent 8cd1c7681d
commit 6c5f5210be
3 changed files with 18 additions and 24 deletions

View file

@ -196,21 +196,22 @@ class TestTranforms(unittest.TestCase):
self.assertIn('(1000)', asm)
def test_binary_subscr_on_unicode(self):
# valid code get optimized
# unicode strings don't get optimized
asm = dis_single('"foo"[0]')
self.assertIn("('f')", asm)
self.assertNotIn('BINARY_SUBSCR', asm)
self.assertNotIn("('f')", asm)
self.assertIn('BINARY_SUBSCR', asm)
asm = dis_single('"\u0061\uffff"[1]')
self.assertIn("('\\uffff')", asm)
self.assertNotIn('BINARY_SUBSCR', asm)
self.assertNotIn("('\\uffff')", asm)
self.assertIn('BINARY_SUBSCR', asm)
# invalid code doesn't get optimized
# out of range
asm = dis_single('"fuu"[10]')
self.assertIn('BINARY_SUBSCR', asm)
# non-BMP char (see #5057)
asm = dis_single('"\U00012345"[0]')
self.assertIn('BINARY_SUBSCR', asm)
asm = dis_single('"\U00012345abcdef"[3]')
self.assertIn('BINARY_SUBSCR', asm)
def test_folding_of_unaryops_on_constants(self):