mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-01 07:33:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Stop binding sys.path as default parameter value in packaging.

Browse source 
The two public functions in database default to sys.path if the given
*paths* argument is None; the private functions don’t have default
values for their arguments anymore, which is fine as the public
functions that call them pass their arguments down.  Likewise in
install, the functions will pass down their *paths* arguments down to
database functions.

A one-line unneeded function in install was removed instead of being
changed, and the few remaining tests that used brute-force restoration
of sys.path have been cleaned up to use sys.path.remove.
This commit is contained in:
Éric Araujo 2011-06-16 23:43:15 +02:00
parent b6be20ca33
commit 6f67765389
4 changed files with 20 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/packaging/tests/test_command_build_ext.py
View file

@ -29,7 +29,6 @@ class BuildExtTestCase(support.TempdirManager,
# Note that we're making changes to sys.path
super(BuildExtTestCase, self).setUp()
self.tmp_dir = self.mkdtemp()
self.sys_path = sys.path, sys.path[:]
sys.path.append(self.tmp_dir)
filename = _get_source_filename()
if os.path.exists(filename):
@ -107,8 +106,7 @@ class BuildExtTestCase(support.TempdirManager,
def tearDown(self):
# Get everything back to normal
unload('xx')
sys.path = self.sys_path[0]
sys.path[:] = self.sys_path[1]
sys.path.remove(self.tmp_dir)
if sys.version > "2.6":
site.USER_BASE = self.old_user_base
build_ext.USER_BASE = self.old_user_base