mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-85283: Build _scproxy extension with limited C API (#111008)

Browse source 
* Replace Py_SETREF(v, NULL) with Py_CLEAR(v).
* Reformat the code.
This commit is contained in:
Victor Stinner 2023-10-18 00:32:53 +02:00 • committed by GitHub
parent a53d7cb672
commit 7029c1a1c5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Modules/_scproxy.c
View file

@ -2,6 +2,10 @@
* Helper method for urllib to fetch the proxy configuration settings
* using the SystemConfiguration framework.
*/
// Need limited C API version 3.13 for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED
#define Py_LIMITED_API 0x030d0000
#include <Python.h>
#include <SystemConfiguration/SystemConfiguration.h>
@ -21,8 +25,7 @@ cfstring_to_pystring(CFStringRef ref)
s = CFStringGetCStringPtr(ref, kCFStringEncodingUTF8);
if (s) {
return PyUnicode_DecodeUTF8(
s, strlen(s), NULL);
return PyUnicode_DecodeUTF8(s, strlen(s), NULL);
} else {
CFIndex len = CFStringGetLength(ref);
@ -43,8 +46,7 @@ cfstring_to_pystring(CFStringRef ref)
PyMem_Free(buf);
return NULL;
} else {
result = PyUnicode_DecodeUTF8(
buf, strlen(buf), NULL);
result = PyUnicode_DecodeUTF8(buf, strlen(buf), NULL);
PyMem_Free(buf);
}
return result;
@ -84,7 +86,7 @@ get_proxy_settings(PyObject* Py_UNUSED(mod), PyObject *Py_UNUSED(ignored))
if (v == NULL) goto error;
r = PyDict_SetItemString(result, "exclude_simple", v);
Py_SETREF(v, NULL);
Py_CLEAR(v);
if (r == -1) goto error;
anArray = CFDictionaryGetValue(proxyDict,
@ -104,13 +106,11 @@ get_proxy_settings(PyObject* Py_UNUSED(mod), PyObject *Py_UNUSED(ignored))
aString = CFArrayGetValueAtIndex(anArray, i);
if (aString == NULL) {
PyTuple_SetItem(v, i, Py_None);
Py_INCREF(Py_None);
PyTuple_SetItem(v, i, Py_NewRef(Py_None));
} else {
PyObject* t = cfstring_to_pystring(aString);
if (!t) {
PyTuple_SetItem(v, i, Py_None);
Py_INCREF(Py_None);
PyTuple_SetItem(v, i, Py_NewRef(Py_None));
} else {
PyTuple_SetItem(v, i, t);
}
@ -148,15 +148,13 @@ set_proxy(PyObject* proxies, const char* proto, CFDictionaryRef proxyDict,
if (h) {
if (aNum) {
int32_t port = cfnum_to_int32(aNum);
v = PyUnicode_FromFormat("http://%U:%ld",
h, (long)port);
v = PyUnicode_FromFormat("http://%U:%ld", h, (long)port);
} else {
v = PyUnicode_FromFormat("http://%U", h);
}
Py_DECREF(h);
if (!v) return -1;
r = PyDict_SetItemString(proxies, proto,
v);
r = PyDict_SetItemString(proxies, proto, v);
Py_DECREF(v);
return r;
}