mirror of
https://github.com/python/cpython.git
synced 2025-07-30 14:44:10 +00:00
bpo-40550: Fix time-of-check/time-of-action issue in subprocess.Popen.send_signal. (GH-20010)
send_signal() now swallows the exception if the process it thought was still alive winds up not to exist anymore (always a plausible race condition despite the checks).
Co-authored-by: Gregory P. Smith <greg@krypto.org>
(cherry picked from commit 01a202ab6b
)
Co-authored-by: Filipe Laíns <lains@archlinux.org>
This commit is contained in:
parent
c1bbca5b00
commit
713b4bbd97
3 changed files with 19 additions and 1 deletions
|
@ -3160,6 +3160,19 @@ class POSIXProcessTestCase(BaseTestCase):
|
|||
# so Popen failed to read it and uses a default returncode instead.
|
||||
self.assertIsNotNone(proc.returncode)
|
||||
|
||||
def test_send_signal_race2(self):
|
||||
# bpo-40550: the process might exist between the returncode check and
|
||||
# the kill operation
|
||||
p = subprocess.Popen([sys.executable, '-c', 'exit(1)'])
|
||||
|
||||
# wait for process to exit
|
||||
while not p.returncode:
|
||||
p.poll()
|
||||
|
||||
with mock.patch.object(p, 'poll', new=lambda: None):
|
||||
p.returncode = None
|
||||
p.send_signal(signal.SIGTERM)
|
||||
|
||||
def test_communicate_repeated_call_after_stdout_close(self):
|
||||
proc = subprocess.Popen([sys.executable, '-c',
|
||||
'import os, time; os.close(1), time.sleep(2)'],
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue