mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-29 11:45:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-128002: simplify asyncio.all_tasks to use PyList_Extend instead of manual iteration (#129942)

Browse source
This commit is contained in:
Kumar Aditya 2025-02-10 14:26:32 +05:30 • committed by GitHub
parent 2abb6a4f13
commit 7246b9124c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Modules/_asynciomodule.c
View file

@ -4102,6 +4102,12 @@ _asyncio_all_tasks_impl(PyObject *module, PyObject *loop)
Py_DECREF(loop); Py_DECREF(loop);
return NULL; return NULL;
} }
if (PyList_Extend(tasks, state->non_asyncio_tasks) < 0) {
Py_DECREF(tasks);
Py_DECREF(loop);
return NULL;
}
PyInterpreterState *interp = PyInterpreterState_Get(); PyInterpreterState *interp = PyInterpreterState_Get();
// Stop the world and traverse the per-thread linked list // Stop the world and traverse the per-thread linked list
// of asyncio tasks for every thread, as well as the // of asyncio tasks for every thread, as well as the
@ -4127,24 +4133,7 @@ _asyncio_all_tasks_impl(PyObject *module, PyObject *loop)
Py_DECREF(loop); Py_DECREF(loop);
return NULL; return NULL;
} }
PyObject *scheduled_iter = PyObject_GetIter(state->non_asyncio_tasks);
if (scheduled_iter == NULL) {
Py_DECREF(tasks);
Py_DECREF(loop);
return NULL;
}
PyObject *item;
while ((item = PyIter_Next(scheduled_iter)) != NULL) {
if (PyList_Append(tasks, item) < 0) {
Py_DECREF(tasks);
Py_DECREF(loop);
Py_DECREF(item);
Py_DECREF(scheduled_iter);
return NULL;
}
Py_DECREF(item);
}
Py_DECREF(scheduled_iter);
// All the tasks are now in the list, now filter the tasks which are done // All the tasks are now in the list, now filter the tasks which are done
PyObject *res = PySet_New(NULL); PyObject *res = PySet_New(NULL);
if (res == NULL) { if (res == NULL) {