mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 11:23:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506)

Browse source 
bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on Python 3.

Here we document that bdist_wininst is only supported on Windows,
and we mark it unsupported otherwise to skip tests.

Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.
This commit is contained in:
Miro Hrončok 2019-07-01 14:12:40 +02:00 • committed by Victor Stinner
parent 84de34e39e
commit 72cd653c4e
3 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Doc/distutils/builtdist.rst
View file

@ -315,8 +315,8 @@ or the :command:`bdist` command with the :option:`!--formats` option::
If you have a pure module distribution (only containing pure Python modules and If you have a pure module distribution (only containing pure Python modules and
packages), the resulting installer will be version independent and have a name packages), the resulting installer will be version independent and have a name
like :file:`foo-1.0.win32.exe`. These installers can even be created on Unix like :file:`foo-1.0.win32.exe`. Note that creating ``wininst`` binary
platforms or Mac OS X. distributions in only supported on Windows systems.
If you have a non-pure distribution, the extensions can only be created on a If you have a non-pure distribution, the extensions can only be created on a
Windows platform, and will be Python version dependent. The installer filename Windows platform, and will be Python version dependent. The installer filename

3
Lib/distutils/command/bdist_wininst.py
View file

@ -55,6 +55,9 @@ class bdist_wininst(Command):
boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize', boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize',
'skip-build'] 'skip-build']
# bpo-10945: bdist_wininst requires mbcs encoding only available on Windows
_unsupported = (sys.platform != "win32")
def initialize_options(self): def initialize_options(self):
self.bdist_dir = None self.bdist_dir = None
self.plat_name = None self.plat_name = None

2
Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst Normal file
View file

@ -0,0 +1,2 @@
Officially drop support for creating bdist_wininst installers on non-Windows
systems.