mirror of
https://github.com/python/cpython.git
synced 2025-08-04 00:48:58 +00:00
gh-99418: Make urllib.parse.urlparse enforce that a scheme must begin with an alphabetical ASCII character. (GH-99421)
Prevent urllib.parse.urlparse from accepting schemes that don't begin with an alphabetical ASCII character.
RFC 3986 defines a scheme like this: `scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )`
RFC 2234 defines an ALPHA like this: `ALPHA = %x41-5A / %x61-7A`
The WHATWG URL spec defines a scheme like this:
`"A URL-scheme string must be one ASCII alpha, followed by zero or more of ASCII alphanumeric, U+002B (+), U+002D (-), and U+002E (.)."`
(cherry picked from commit 439b9cfaf4
)
Co-authored-by: Ben Kallus <49924171+kenballus@users.noreply.github.com>
This commit is contained in:
parent
eac1a63cdb
commit
72d356e358
3 changed files with 21 additions and 1 deletions
|
@ -668,6 +668,24 @@ class UrlParseTestCase(unittest.TestCase):
|
|||
with self.assertRaises(ValueError):
|
||||
p.port
|
||||
|
||||
def test_attributes_bad_scheme(self):
|
||||
"""Check handling of invalid schemes."""
|
||||
for bytes in (False, True):
|
||||
for parse in (urllib.parse.urlsplit, urllib.parse.urlparse):
|
||||
for scheme in (".", "+", "-", "0", "http&", "६http"):
|
||||
with self.subTest(bytes=bytes, parse=parse, scheme=scheme):
|
||||
url = scheme + "://www.example.net"
|
||||
if bytes:
|
||||
if url.isascii():
|
||||
url = url.encode("ascii")
|
||||
else:
|
||||
continue
|
||||
p = parse(url)
|
||||
if bytes:
|
||||
self.assertEqual(p.scheme, b"")
|
||||
else:
|
||||
self.assertEqual(p.scheme, "")
|
||||
|
||||
def test_attributes_without_netloc(self):
|
||||
# This example is straight from RFC 3261. It looks like it
|
||||
# should allow the username, hostname, and port to be filled
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue