mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Issue #13355: Raise ValueError on random.triangular call with invalid params.

Browse source 
Initial patch by Yuriy Senko.
This commit is contained in:
Andrew Svetlov 2013-04-12 23:27:37 +03:00
commit 730001163f
4 changed files with 42 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Lib/test/test_random.py
View file

@ -48,6 +48,33 @@ class TestBasicOps(unittest.TestCase):
self.assertRaises(TypeError, self.gen.seed, 1, 2, 3, 4)
self.assertRaises(TypeError, type(self.gen), [])
def test_triangular(self):
# Check that triangular() correctly handles bad input. See issue 13355.
# mode > high.
with self.assertRaises(ValueError):
random.triangular(mode=2)
with self.assertRaises(ValueError):
random.triangular(low=1, high=10, mode=11)
with self.assertRaises(ValueError):
random.triangular(low=1, high=1, mode=11)
# mode < low.
with self.assertRaises(ValueError):
random.triangular(mode=-1)
with self.assertRaises(ValueError):
random.triangular(low=1, high=10, mode=0)
with self.assertRaises(ValueError):
random.triangular(low=1, high=1, mode=0)
# low > high
with self.assertRaises(ValueError):
random.triangular(low=5, high=2)
with self.assertRaises(ValueError):
random.triangular(low=5, high=2, mode=1)
with self.assertRaises(ValueError):
random.triangular(low=-2, high=-5)
self.assertEqual(random.triangular(low=10, high=10), 10)
self.assertEqual(random.triangular(low=10, high=10, mode=10), 10)
@unittest.mock.patch('random._urandom') # os.urandom
def test_seed_when_randomness_source_not_found(self, urandom_mock):
# Random.seed() uses time.time() when an operating system specific
@ -73,7 +100,6 @@ class TestBasicOps(unittest.TestCase):
for (seq, shuffled_seq) in zip(seqs, shuffled_seqs):
self.assertEqual(len(seq), len(shuffled_seq))
self.assertEqual(set(seq), set(shuffled_seq))
# The above tests all would pass if the shuffle was a
# no-op. The following non-deterministic test covers that. It
# asserts that the shuffled sequence of 1000 distinct elements
@ -597,7 +623,7 @@ class TestDistributions(unittest.TestCase):
for variate, args, expected in [
(g.uniform, (10.0, 10.0), 10.0),
(g.triangular, (10.0, 10.0), 10.0),
#(g.triangular, (10.0, 10.0, 10.0), 10.0),
(g.triangular, (10.0, 10.0, 10.0), 10.0),
(g.expovariate, (float('inf'),), 0.0),
(g.vonmisesvariate, (3.0, float('inf')), 3.0),
(g.gauss, (10.0, 0.0), 10.0),