mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Isue #5084: unpickling now interns the attribute names of pickled objects,

Browse source 
saving memory and avoiding growth in size of subsequent pickles. Proposal
and original patch by Jake McGuire.
This commit is contained in:
Antoine Pitrou 2009-05-02 21:13:23 +00:00
parent 2b42c29a50
commit 7430989cda
4 changed files with 36 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Modules/cPickle.c
View file

@ -4473,8 +4473,16 @@ load_build(Unpicklerobject *self)
i = 0;
while (PyDict_Next(state, &i, &d_key, &d_value)) {
if (PyObject_SetItem(dict, d_key, d_value) < 0)
/* normally the keys for instance attributes are
interned. we should try to do that here. */
Py_INCREF(d_key);
if (PyString_CheckExact(d_key))
PyString_InternInPlace(&d_key);
if (PyObject_SetItem(dict, d_key, d_value) < 0) {
Py_DECREF(d_key);
goto finally;
}
Py_DECREF(d_key);
}
Py_DECREF(dict);
}