mirror of
https://github.com/python/cpython.git
synced 2025-09-27 02:39:58 +00:00
bpo-35246: fix support for path-like args in asyncio subprocess (GH-13628)
Drop isinstance checks from create_subprocess_exec function and let subprocess module do them. https://bugs.python.org/issue35246 https://bugs.python.org/issue35246
This commit is contained in:
parent
e1f95e77e0
commit
744c08a9c7
3 changed files with 12 additions and 5 deletions
|
@ -1605,11 +1605,6 @@ class BaseEventLoop(events.AbstractEventLoop):
|
||||||
raise ValueError("errors must be None")
|
raise ValueError("errors must be None")
|
||||||
|
|
||||||
popen_args = (program,) + args
|
popen_args = (program,) + args
|
||||||
for arg in popen_args:
|
|
||||||
if not isinstance(arg, (str, bytes)):
|
|
||||||
raise TypeError(
|
|
||||||
f"program arguments must be a bytes or text string, "
|
|
||||||
f"not {type(arg).__name__}")
|
|
||||||
protocol = protocol_factory()
|
protocol = protocol_factory()
|
||||||
debug_log = None
|
debug_log = None
|
||||||
if self._debug:
|
if self._debug:
|
||||||
|
|
|
@ -622,6 +622,17 @@ class SubprocessMixin:
|
||||||
self.loop.run_until_complete(execute())
|
self.loop.run_until_complete(execute())
|
||||||
|
|
||||||
|
|
||||||
|
def test_create_subprocess_exec_with_path(self):
|
||||||
|
async def execute():
|
||||||
|
p = await subprocess.create_subprocess_exec(
|
||||||
|
support.FakePath(sys.executable), '-c', 'pass')
|
||||||
|
await p.wait()
|
||||||
|
p = await subprocess.create_subprocess_exec(
|
||||||
|
sys.executable, '-c', 'pass', support.FakePath('.'))
|
||||||
|
await p.wait()
|
||||||
|
|
||||||
|
self.assertIsNone(self.loop.run_until_complete(execute()))
|
||||||
|
|
||||||
if sys.platform != 'win32':
|
if sys.platform != 'win32':
|
||||||
# Unix
|
# Unix
|
||||||
class SubprocessWatcherMixin(SubprocessMixin):
|
class SubprocessWatcherMixin(SubprocessMixin):
|
||||||
|
|
|
@ -0,0 +1 @@
|
||||||
|
Make :func:`asyncio.create_subprocess_exec` accept path-like arguments.
|
Loading…
Add table
Add a link
Reference in a new issue