mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Add a format specifier %R to PyUnicode_FromFormat(), which embeds

Browse source 
the result of a call to PyObject_Repr() into the string. This makes
it possible to simplify many repr implementations.

PyUnicode_FromFormat() uses two steps to create the final string: A first
pass through the format string determines the size of the final string and
a second pass creates the string. To avoid calling PyObject_Repr() twice
for each %R specifier, PyObject_Repr() is called during the size
calculation step and the results are stored in an array (whose size is
determined at the start by counting %R specifiers).
This commit is contained in:
Walter Dörwald 2007-05-19 21:49:49 +00:00
parent 94b59bb144
commit 7569dfe11d
12 changed files with 125 additions and 149 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Modules/_elementtree.c
View file

@ -1118,17 +1118,7 @@ element_remove(ElementObject* self, PyObject* args)
static PyObject*
element_repr(ElementObject* self)
{
PyObject* repr;
char buffer[100];
repr = PyUnicode_FromString("<Element ");
PyUnicode_AppendAndDel(&repr, PyObject_Repr(self->tag));
sprintf(buffer, " at %p>", self);
PyUnicode_AppendAndDel(&repr, PyUnicode_FromString(buffer));
return repr;
return PyUnicode_FromFormat("<Element %R at %p>", self->tag, self);
}
static PyObject*