mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-21 01:15:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

If you created a weakref in an object's __del__ method to itself it would

Browse source 
segfault the interpreter during weakref clean up.  Now any new weakrefs created
after __del__ is run are removed silently.

Fixes bug #1377858 and the weakref_in_del crasher for new-style classes.
Classic classes are still affected.
This commit is contained in:
Brett Cannon 2007-01-23 22:41:20 +00:00
parent 601d03a5be
commit 75ba075110
5 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Objects/weakrefobject.c
View file

@ -57,6 +57,9 @@ clear_weakref(PyWeakReference *self)
PyWeakref_GET_OBJECT(self));
if (*list == self)
/* If 'self' is the end of the list (and thus self->wr_next == NULL)
then the weakref list itself (and thus the value of *list) will
end up being set to NULL. */
*list = self->wr_next;
self->wr_object = Py_None;
if (self->wr_prev != NULL)