mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

SETUP_WITH acts like SETUP_FINALLY for the purposes of setting f_lineno (closes #14612)

Browse source
This commit is contained in:
Benjamin Peterson 2012-04-18 11:14:31 -04:00
parent 33c66301ee
commit 76605557ea
3 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Lib/test/test_sys_settrace.py
View file

@ -670,6 +670,14 @@ def no_jump_to_non_integers(output):
no_jump_to_non_integers.jump = (2, "Spam") no_jump_to_non_integers.jump = (2, "Spam")
no_jump_to_non_integers.output = [True] no_jump_to_non_integers.output = [True]
def jump_across_with(output):
with open(test_support.TESTFN, "wb") as fp:
pass
with open(test_support.TESTFN, "wb") as fp:
pass
jump_across_with.jump = (1, 3)
jump_across_with.output = []
# This verifies that you can't set f_lineno via _getframe or similar # This verifies that you can't set f_lineno via _getframe or similar
# trickery. # trickery.
def no_jump_without_trace_function(): def no_jump_without_trace_function():
@ -739,6 +747,9 @@ class JumpTestCase(unittest.TestCase):
self.run_test(no_jump_to_non_integers) self.run_test(no_jump_to_non_integers)
def test_19_no_jump_without_trace_function(self): def test_19_no_jump_without_trace_function(self):
no_jump_without_trace_function() no_jump_without_trace_function()
def test_jump_across_with(self):
self.addCleanup(test_support.unlink, test_support.TESTFN)
self.run_test(jump_across_with)
def test_20_large_function(self): def test_20_large_function(self):
d = {} d = {}

2
Misc/NEWS
View file

@ -9,6 +9,8 @@ What's New in Python 2.7.4
Core and Builtins Core and Builtins
----------------- -----------------
- Issue #14612: Fix jumping around with blocks by setting f_lineno.
- Issue #13889: Check and (if necessary) set FPU control word before calling - Issue #13889: Check and (if necessary) set FPU control word before calling
any of the dtoa.c string <-> float conversion functions, on MSVC builds of any of the dtoa.c string <-> float conversion functions, on MSVC builds of
Python. This fixes issues when embedding Python in a Delphi app. Python. This fixes issues when embedding Python in a Delphi app.

6
Objects/frameobject.c
View file

@ -214,6 +214,7 @@ frame_setlineno(PyFrameObject *f, PyObject* p_new_lineno)
case SETUP_LOOP: case SETUP_LOOP:
case SETUP_EXCEPT: case SETUP_EXCEPT:
case SETUP_FINALLY: case SETUP_FINALLY:
case SETUP_WITH:
blockstack[blockstack_top++] = addr; blockstack[blockstack_top++] = addr;
in_finally[blockstack_top-1] = 0; in_finally[blockstack_top-1] = 0;
break; break;
@ -221,7 +222,7 @@ frame_setlineno(PyFrameObject *f, PyObject* p_new_lineno)
case POP_BLOCK: case POP_BLOCK:
assert(blockstack_top > 0); assert(blockstack_top > 0);
setup_op = code[blockstack[blockstack_top-1]]; setup_op = code[blockstack[blockstack_top-1]];
if (setup_op == SETUP_FINALLY) { if (setup_op == SETUP_FINALLY || setup_op == SETUP_WITH) {
in_finally[blockstack_top-1] = 1; in_finally[blockstack_top-1] = 1;
} }
else { else {
@ -236,7 +237,7 @@ frame_setlineno(PyFrameObject *f, PyObject* p_new_lineno)
* be seeing such an END_FINALLY.) */ * be seeing such an END_FINALLY.) */
if (blockstack_top > 0) { if (blockstack_top > 0) {
setup_op = code[blockstack[blockstack_top-1]]; setup_op = code[blockstack[blockstack_top-1]];
if (setup_op == SETUP_FINALLY) { if (setup_op == SETUP_FINALLY || setup_op == SETUP_WITH) {
blockstack_top--; blockstack_top--;
} }
} }
@ -298,6 +299,7 @@ frame_setlineno(PyFrameObject *f, PyObject* p_new_lineno)
case SETUP_LOOP: case SETUP_LOOP:
case SETUP_EXCEPT: case SETUP_EXCEPT:
case SETUP_FINALLY: case SETUP_FINALLY:
case SETUP_WITH:
delta_iblock++; delta_iblock++;
break; break;