Fixes issue #19506: Use a memoryview to avoid a data copy when piping data

to stdin within subprocess.Popen.communicate.  5-10% less cpu usage.
This commit is contained in:
Gregory P. Smith 2013-12-07 19:12:46 -08:00
parent 6c527cf37f
commit 774f909489
2 changed files with 8 additions and 2 deletions

View file

@ -1621,6 +1621,9 @@ class Popen(object):
self._save_input(input)
if self._input:
input_view = memoryview(self._input)
while self._fd2file:
timeout = self._remaining_time(endtime)
if timeout is not None and timeout < 0:
@ -1638,8 +1641,8 @@ class Popen(object):
for fd, mode in ready:
if mode & select.POLLOUT:
chunk = self._input[self._input_offset :
self._input_offset + _PIPE_BUF]
chunk = input_view[self._input_offset :
self._input_offset + _PIPE_BUF]
try:
self._input_offset += os.write(fd, chunk)
except OSError as e:

View file

@ -18,6 +18,9 @@ Core and Builtins
Library
-------
- Issue #19506: Use a memoryview to avoid a data copy when piping data
to stdin within subprocess.Popen.communicate. 5-10% less cpu usage.
- Issue #19839: Fix regression in bz2 module's handling of non-bzip2 data at
EOF, and analogous bug in lzma module.