mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-29 21:25:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-100227: Lock Around Use of the Global "atexit" State (gh-105514)

Browse source 
The risk of a race with this state is relatively low, but we play it safe anyway.
This commit is contained in:
Eric Snow 2023-06-08 12:08:28 -06:00 • committed by GitHub
parent 6a8b862357
commit 7799c8e678
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Python/pylifecycle.c
View file

@ -2973,24 +2973,35 @@ wait_for_thread_shutdown(PyThreadState *tstate)
int Py_AtExit(void (*func)(void))
{
if (_PyRuntime.atexit.ncallbacks >= NEXITFUNCS)
struct _atexit_runtime_state *state = &_PyRuntime.atexit;
PyThread_acquire_lock(state->mutex, WAIT_LOCK);
if (state->ncallbacks >= NEXITFUNCS) {
PyThread_release_lock(state->mutex);
return -1;
_PyRuntime.atexit.callbacks[_PyRuntime.atexit.ncallbacks++] = func;
}
state->callbacks[state->ncallbacks++] = func;
PyThread_release_lock(state->mutex);
return 0;
}
static void
call_ll_exitfuncs(_PyRuntimeState *runtime)
{
atexit_callbackfunc exitfunc;
struct _atexit_runtime_state *state = &runtime->atexit;
PyThread_acquire_lock(state->mutex, WAIT_LOCK);
while (state->ncallbacks > 0) {
/* pop last function from the list */
state->ncallbacks--;
atexit_callbackfunc exitfunc = state->callbacks[state->ncallbacks];
exitfunc = state->callbacks[state->ncallbacks];
state->callbacks[state->ncallbacks] = NULL;
PyThread_release_lock(state->mutex);
exitfunc();
PyThread_acquire_lock(state->mutex, WAIT_LOCK);
}
PyThread_release_lock(state->mutex);
fflush(stdout);
fflush(stderr);