mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-20 15:40:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix core dump in PyArg_ParseTuple() with Unicode arguments.

Browse source 
Reported by Fredrik Lundh on python-dev.

The conversimple() code that handles Unicode arguments and converts
them to the default encoding now calls converterr() with the original
Unicode argument instead of the NULL returned by the failed encoding
attempt.
This commit is contained in:
Jeremy Hylton 2001-09-10 01:54:43 +00:00
parent bea3fb83a7
commit 77b8b67919
1 changed files with 17 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Python/getargs.c
View file

@ -368,6 +368,7 @@ static char *
converterr(char *expected, PyObject *arg, char *msgbuf) converterr(char *expected, PyObject *arg, char *msgbuf)
{ {
assert(expected != NULL); assert(expected != NULL);
assert(arg != NULL);
sprintf(msgbuf, "must be %.50s, not %.50s", expected, sprintf(msgbuf, "must be %.50s, not %.50s", expected,
arg == Py_None ? "None" : arg->ob_type->tp_name); arg == Py_None ? "None" : arg->ob_type->tp_name);
return msgbuf; return msgbuf;
@ -387,6 +388,7 @@ convertsimple(PyObject *arg, char **p_format, va_list *p_va, char *msgbuf)
{ {
char *format = *p_format; char *format = *p_format;
char c = *format++; char c = *format++;
PyObject *uarg;
switch (c) { switch (c) {
@ -568,12 +570,12 @@ convertsimple(PyObject *arg, char **p_format, va_list *p_va, char *msgbuf)
} }
#ifdef Py_USING_UNICODE #ifdef Py_USING_UNICODE
else if (PyUnicode_Check(arg)) { else if (PyUnicode_Check(arg)) {
arg = UNICODE_DEFAULT_ENCODING(arg); uarg = UNICODE_DEFAULT_ENCODING(arg);
if (arg == NULL) if (uarg == NULL)
return converterr(CONV_UNICODE, return converterr(CONV_UNICODE,
arg, msgbuf); arg, msgbuf);
*p = PyString_AS_STRING(arg); *p = PyString_AS_STRING(uarg);
*q = PyString_GET_SIZE(arg); *q = PyString_GET_SIZE(uarg);
} }
#endif #endif
else { /* any buffer-like object */ else { /* any buffer-like object */
@ -591,11 +593,11 @@ convertsimple(PyObject *arg, char **p_format, va_list *p_va, char *msgbuf)
*p = PyString_AS_STRING(arg); *p = PyString_AS_STRING(arg);
#ifdef Py_USING_UNICODE #ifdef Py_USING_UNICODE
else if (PyUnicode_Check(arg)) { else if (PyUnicode_Check(arg)) {
arg = UNICODE_DEFAULT_ENCODING(arg); uarg = UNICODE_DEFAULT_ENCODING(arg);
if (arg == NULL) if (uarg == NULL)
return converterr(CONV_UNICODE, return converterr(CONV_UNICODE,
arg, msgbuf); arg, msgbuf);
*p = PyString_AS_STRING(arg); *p = PyString_AS_STRING(uarg);
} }
#endif #endif
else else
@ -622,12 +624,12 @@ convertsimple(PyObject *arg, char **p_format, va_list *p_va, char *msgbuf)
} }
#ifdef Py_USING_UNICODE #ifdef Py_USING_UNICODE
else if (PyUnicode_Check(arg)) { else if (PyUnicode_Check(arg)) {
arg = UNICODE_DEFAULT_ENCODING(arg); uarg = UNICODE_DEFAULT_ENCODING(arg);
if (arg == NULL) if (uarg == NULL)
return converterr(CONV_UNICODE, return converterr(CONV_UNICODE,
arg, msgbuf); arg, msgbuf);
*p = PyString_AS_STRING(arg); *p = PyString_AS_STRING(uarg);
*q = PyString_GET_SIZE(arg); *q = PyString_GET_SIZE(uarg);
} }
#endif #endif
else { /* any buffer-like object */ else { /* any buffer-like object */
@ -648,11 +650,11 @@ convertsimple(PyObject *arg, char **p_format, va_list *p_va, char *msgbuf)
*p = PyString_AsString(arg); *p = PyString_AsString(arg);
#ifdef Py_USING_UNICODE #ifdef Py_USING_UNICODE
else if (PyUnicode_Check(arg)) { else if (PyUnicode_Check(arg)) {
arg = UNICODE_DEFAULT_ENCODING(arg); uarg = UNICODE_DEFAULT_ENCODING(arg);
if (arg == NULL) if (uarg == NULL)
return converterr(CONV_UNICODE, return converterr(CONV_UNICODE,
arg, msgbuf); arg, msgbuf);
*p = PyString_AS_STRING(arg); *p = PyString_AS_STRING(uarg);
} }
#endif #endif
else else