mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-12 09:53:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

gh-111019: Align expected and actual titles in test output (#111020)

Browse source 
Align expected and actual titles in output from
assert_has_calls/assert_called_with for greater readability
This commit is contained in:
James 2023-10-18 03:36:16 -04:00 • committed by GitHub
parent 738574fb21
commit 77dbd95609
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Lib/test/test_unittest/testmock/testmock.py
View file

@ -1058,7 +1058,7 @@ class MockTest(unittest.TestCase):
actual = 'not called.' actual = 'not called.'
expected = "mock(1, '2', 3, bar='foo')" expected = "mock(1, '2', 3, bar='foo')"
message = 'expected call not found.\nExpected: %s\nActual: %s' message = 'expected call not found.\nExpected: %s\n Actual: %s'
self.assertRaisesWithMsg( self.assertRaisesWithMsg(
AssertionError, message % (expected, actual), AssertionError, message % (expected, actual),
mock.assert_called_with, 1, '2', 3, bar='foo' mock.assert_called_with, 1, '2', 3, bar='foo'
@ -1073,7 +1073,7 @@ class MockTest(unittest.TestCase):
for meth in asserters: for meth in asserters:
actual = "foo(1, '2', 3, foo='foo')" actual = "foo(1, '2', 3, foo='foo')"
expected = "foo(1, '2', 3, bar='foo')" expected = "foo(1, '2', 3, bar='foo')"
message = 'expected call not found.\nExpected: %s\nActual: %s' message = 'expected call not found.\nExpected: %s\n Actual: %s'
self.assertRaisesWithMsg( self.assertRaisesWithMsg(
AssertionError, message % (expected, actual), AssertionError, message % (expected, actual),
meth, 1, '2', 3, bar='foo' meth, 1, '2', 3, bar='foo'
@ -1083,7 +1083,7 @@ class MockTest(unittest.TestCase):
for meth in asserters: for meth in asserters:
actual = "foo(1, '2', 3, foo='foo')" actual = "foo(1, '2', 3, foo='foo')"
expected = "foo(bar='foo')" expected = "foo(bar='foo')"
message = 'expected call not found.\nExpected: %s\nActual: %s' message = 'expected call not found.\nExpected: %s\n Actual: %s'
self.assertRaisesWithMsg( self.assertRaisesWithMsg(
AssertionError, message % (expected, actual), AssertionError, message % (expected, actual),
meth, bar='foo' meth, bar='foo'
@ -1093,7 +1093,7 @@ class MockTest(unittest.TestCase):
for meth in asserters: for meth in asserters:
actual = "foo(1, '2', 3, foo='foo')" actual = "foo(1, '2', 3, foo='foo')"
expected = "foo(1, 2, 3)" expected = "foo(1, 2, 3)"
message = 'expected call not found.\nExpected: %s\nActual: %s' message = 'expected call not found.\nExpected: %s\n Actual: %s'
self.assertRaisesWithMsg( self.assertRaisesWithMsg(
AssertionError, message % (expected, actual), AssertionError, message % (expected, actual),
meth, 1, 2, 3 meth, 1, 2, 3
@ -1103,7 +1103,7 @@ class MockTest(unittest.TestCase):
for meth in asserters: for meth in asserters:
actual = "foo(1, '2', 3, foo='foo')" actual = "foo(1, '2', 3, foo='foo')"
expected = "foo()" expected = "foo()"
message = 'expected call not found.\nExpected: %s\nActual: %s' message = 'expected call not found.\nExpected: %s\n Actual: %s'
self.assertRaisesWithMsg( self.assertRaisesWithMsg(
AssertionError, message % (expected, actual), meth AssertionError, message % (expected, actual), meth
) )
@ -1552,7 +1552,7 @@ class MockTest(unittest.TestCase):
'^{}$'.format( '^{}$'.format(
re.escape('Calls not found.\n' re.escape('Calls not found.\n'
'Expected: [call()]\n' 'Expected: [call()]\n'
'Actual: [call(1)]'))) as cm: ' Actual: [call(1)]'))) as cm:
mock.assert_has_calls([call()]) mock.assert_has_calls([call()])
self.assertIsNone(cm.exception.__cause__) self.assertIsNone(cm.exception.__cause__)
@ -1564,7 +1564,7 @@ class MockTest(unittest.TestCase):
'Error processing expected calls.\n' 'Error processing expected calls.\n'
"Errors: [None, TypeError('too many positional arguments')]\n" "Errors: [None, TypeError('too many positional arguments')]\n"
"Expected: [call(), call(1, 2)]\n" "Expected: [call(), call(1, 2)]\n"
'Actual: [call(1)]'))) as cm: ' Actual: [call(1)]'))) as cm:
mock.assert_has_calls([call(), call(1, 2)]) mock.assert_has_calls([call(), call(1, 2)])
self.assertIsInstance(cm.exception.__cause__, TypeError) self.assertIsInstance(cm.exception.__cause__, TypeError)

6
Lib/unittest/mock.py
View file

@ -857,7 +857,7 @@ class NonCallableMock(Base):
def _format_mock_failure_message(self, args, kwargs, action='call'): def _format_mock_failure_message(self, args, kwargs, action='call'):
message = 'expected %s not found.\nExpected: %s\nActual: %s' message = 'expected %s not found.\nExpected: %s\n Actual: %s'
expected_string = self._format_mock_call_signature(args, kwargs) expected_string = self._format_mock_call_signature(args, kwargs)
call_args = self.call_args call_args = self.call_args
actual_string = self._format_mock_call_signature(*call_args) actual_string = self._format_mock_call_signature(*call_args)
@ -960,7 +960,7 @@ class NonCallableMock(Base):
if self.call_args is None: if self.call_args is None:
expected = self._format_mock_call_signature(args, kwargs) expected = self._format_mock_call_signature(args, kwargs)
actual = 'not called.' actual = 'not called.'
error_message = ('expected call not found.\nExpected: %s\nActual: %s' error_message = ('expected call not found.\nExpected: %s\n Actual: %s'
% (expected, actual)) % (expected, actual))
raise AssertionError(error_message) raise AssertionError(error_message)
@ -1011,7 +1011,7 @@ class NonCallableMock(Base):
raise AssertionError( raise AssertionError(
f'{problem}\n' f'{problem}\n'
f'Expected: {_CallList(calls)}' f'Expected: {_CallList(calls)}'
f'{self._calls_repr(prefix="Actual").rstrip(".")}' f'{self._calls_repr(prefix=" Actual").rstrip(".")}'
) from cause ) from cause
return return