mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-103607: Fix pause_reading to work when called from connection_made in asyncio. (#17425)

Browse source 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
This commit is contained in:
Itayazolay 2023-04-27 13:03:29 +03:00 • committed by GitHub
parent dff8e5dc8d
commit 78942ecd9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 62 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Lib/asyncio/unix_events.py
View file

@ -485,13 +485,21 @@ class _UnixReadPipeTransport(transports.ReadTransport):
self._loop.call_soon(self._protocol.connection_made, self)
# only start reading when connection_made() has been called
self._loop.call_soon(self._loop._add_reader,
self._loop.call_soon(self._add_reader,
self._fileno, self._read_ready)
if waiter is not None:
# only wake up the waiter when connection_made() has been called
self._loop.call_soon(futures._set_result_unless_cancelled,
waiter, None)
def _add_reader(self, fd, callback):
if not self.is_reading():
return
self._loop._add_reader(fd, callback)
def is_reading(self):
return not self._paused and not self._closing
def __repr__(self):
info = [self.__class__.__name__]
if self._pipe is None:
@ -532,7 +540,7 @@ class _UnixReadPipeTransport(transports.ReadTransport):
self._loop.call_soon(self._call_connection_lost, None)
def pause_reading(self):
if self._closing or self._paused:
if not self.is_reading():
return
self._paused = True
self._loop._remove_reader(self._fileno)