mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-122133: Authenticate socket connection for socket.socketpair() fallback (GH-122134)

Browse source 
* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

Co-authored-by: Gregory P. Smith <greg@krypto.org>
This commit is contained in:
Seth Michael Larson 2024-07-29 16:44:35 -05:00 • committed by GitHub
parent 76bdfa4cd0
commit 78df1043db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 147 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Lib/socket.py
View file

@ -650,6 +650,23 @@ else:
raise
finally:
lsock.close()
# Authenticating avoids using a connection from something else
# able to connect to {host}:{port} instead of us.
# We expect only AF_INET and AF_INET6 families.
try:
if (
ssock.getsockname() != csock.getpeername()
or csock.getsockname() != ssock.getpeername()
):
raise ConnectionError("Unexpected peer connection")
except:
# getsockname() and getpeername() can fail
# if either socket isn't connected.
ssock.close()
csock.close()
raise
return (ssock, csock)
__all__.append("socketpair")